!build

I suggest adding a flag that allows merging adjacent tiles (should be on by default in my opinion).

Should be optional, because not merging can also be useful for example in this usecase.

Merged:

Unmerged:

(have renamed Merge to Merge Adjacent Tiles )

Looks good now ? @timon-schelling

That's just merging rows, not every adjacent tile. Can you fix that?

That's just merging rows, not every adjacent tile. Can you fix that?

1. ig think all adjacent tiles(rows and columns) are merging already.
2. you mean there shouldnt be gap btn 4 boxed-adjacent tiles?

As you can see here in your screenshot, row are merged, collums are not merged.
I can tell because the side has indents.

Could we just make the shape be boxes and then use a boolean union operation to merge them? Or we could just use a manual flood fill to build contiguous regions

I tried using flood fill approach ( ig first one will be heavier):

!build

The node is currently nondeterministic. It produces different data every evaluation.

@Sahil-Gupta584 Due to the use of a Hash Set which uses randomization under the hood, the flood fill algorithm will start from a different point each time, leading to visually identical but different output in each evaluation. This should be relatively easy to fix since in some cases, the HashSet you used is just not necessary. You could for example replace the HashSet in initial calculation of the remaining pixels with a Vec etc., but please do yourself the favor of trying to understand the algorithm that is implemented and fix it without relying on ai tools for this task. The function is pretty sure and this might take a bit longer, but I think this would be a good learning opportunity

sure, thanks for the suggestions, looks interesting for me also!

So i tried making code more deterministic as well added few comments for understanding working.

!build

error[E0599]: no function or associated item named `new_rect` found for struct `vector_types::Subpath<PointId>` in the current scope
   --> node-graph/nodes/vector/src/generator_nodes.rs:208:46
    |
208 |                     vector.append_subpath(subpath::Subpath::new_rect(corner1, corner2), false);
    |                                                             ^^^^^^^^ function or associated item not found in `vector_types::Subpath<_>`
    |

not working as intended

@Sahil-Gupta584 are you interested in continuing this?

@Sahil-Gupta584 are you interested in continuing this?

Yes of course, just need few more days more.

I will notify on discord after fixing ci and testing things.

!build

In our testing, the flood fill now seems to work, so I guess we should give this another round of review

I guess having the ecc setting be exposed users would be useful.

I guess having the ecc setting be exposed to users would be useful.

I added this, I would be fine with merging. @TrueDoctor

!build

!build

Sorry guys couldnt be active much, having many things parallely.
Will try to update my other prs soon.

!build

Please leave a comment in #3565 so you can be assigned to that issue.

You mean in #3468 ? done!